[PATCH 2/2] realtek: add support for HPE 1920-24G-PoE-370w

[Evan Jobling]

On 22/9/24 19:50, Bjørn Mork wrote:
 
> I believe that's pretty much it.  If you already have a "cooling-device"
> implementation using the gpio-fan driver, then you just have to extend
> the thermal-zone with cooling-maps and trips.  See
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
> 
> The RPi PoE hat device tree overlay is another example of adding a
> cooling-device (fan) into an existing thermal-zone with a sensor:
> 
> https://github.com/raspberrypi/linux/blob/rpi-6.6.y/arch/arm/boot/dts/overlays/rpi-poe-overlay.dts
> 
> We obviously don't want overlays - just think of it as a device tree
> diff.  And the trip point params are also irrelevant.  AFAICS,
> thermal_of will set THERMAL_TRIP_FLAG_RW_TEMP. So the trip points should
> be configurable from userspace using sysfs.  Unless I'm missing
> something.
> 
> In any case, a fixed high/low setting like OEM is probably good enough
> for most users.

OK thanks. I did some reading on thermal zones trying to find a way to set
default fans. Need to do more reading. Thanks for the heads up.

> 
> I've never written thermal drver either.  There's only one way out of
> that :-)
> 
Okay cool. More reading in my future to do things kernel safe I guess.

> 
> Bjørn