[PATCH 2/2] realtek: add support for HPE 1920-24G-PoE-370w

[Evan Jobling]

Thanks Tim for your feedback!

On 18/9/24 21:23, Tim Small wrote:
> Hi,
> 
> I prepared a patch for this switch about 6 months ago, but never got around to submitting it.
Awesome, great to compare notes. I wasn't aware of this prior work.

I don't have a JG925A to test so I wasn't game to submit for that.
Everything else looks similar which is nice.
> 
> The OEM firmware seems to do fan speed control in firmware - although the algorithm used is not obvious - it's probably temperature sensor or total power draw feedback, or some combination of the two.  Additionally when one fan fails the others go full-speed (and log faults).
> 
So your feedback here is to get this merged, I should change the fan control into the DTS as you have done?
I just checked that the fan GPIO pin was the same as the JG922A that was already merged.
(i.e. under 03_gpio_switches) 
I was also unaware that there was another GPIO for fan failure so that's great news.
> The best policy is unfortunately probably to run the fans at full speed by default.

I guess then we should also submit a patch so the default for the JG922A is also max?
Then the user can elect to turn down the fans?

Cheers,
Evan.