[PATCH] ath79: consistent network configuration of 2-port APs

[Henrique de Moraes Holschuh]

Em 04/05/2022 06:04, Thibaut VARÈNE escreveu:
> In ath79 we have two groups of indoor/outdoor 2-port APs: one where
> both ports are assigned to the lan interface, and one where an
> arbitrarily chosen port is assigned to the wan interface.
> 
>  From a look at the device pictures, it seems none of them make that
> distinction on their casing, so this patch moves the second group in
> line with the first.

IMO, this is going to expose anyone who upgrades into a firmware that 
has these changes [possibly after a factory-reset] to something that is 
very dangerous[1].

So, IMHO, this sort of change *MUST* be listed in the next stable 
RELEASE NOTES as an "incompatible change".

Also IMO, the only way for this to work is to have an in-tree list of 
what-needs-to-be-in-next-RELEASE_NOTES, and enforce that any such 
changes landing in the tree also update that file (and, when 
desired/required, bump the sysupgrade image config version guard).


Note that I am not opposing the change.  I just think we should at some 
point (preferably now) ensure that such changes to be less of a pitfall 
to downstream and users.


[1] as in: when it goes from WAN to LAN, a port that is *physically* 
connected to the WAN circuit suddenly becomes a bridge, and connects 
that WAN circuit to the LAN circuit.  And yes, obviously applies to 
VLANs as well.  Switching a port from LAN to WAN is also bad, and it can 
be just as dangerous depending on several factors.

-- 
Henrique de Moraes Holschuh