[PATCH 6/6] qoriq: add support for WatchGuard Firebox M300

Stijn Tintel stijn at linux-ipv6.be
Wed Aug 25 11:01:45 PDT 2021

On 24/08/2021 15:41, Adrian Schmutzler wrote:
> Hi,
>>>> +			reg = <0x00 0x10000>;
>>>> +			label = "NOR (RW) LANNER RCW Code";
>>> Labels here might need some refactoring, too.
>> Since we're not really touching anything on the NOR (yet), I prefer to 
>> keep the OEM names for now. What else would you suggest?
> I would at least remove the "NOR (RW)" prefix, but I won't cry if you don't
> ...
> Two other comments from your staging tree:
>> compatible = "watchguard,firebox-m300", "fsl,T2081QDS";
> Is the latter still "correct" for this device?
>> +	  kmod-hwmon-w83793 kmod-ptp-qoriq kmod-rtc-rs5c372a 
>> +kmod-tpm-i2c-atmel
> We typically use (just) one tab for hanging indent in image/*.mk files.
> (I.e. remove the additional spaces before kmod-hwmon...

That's an editor with its own will, and an oversight on my end. I should
probably convince the editor to stop doing that. Fixed.


More information about the openwrt-devel mailing list