[OpenWrt-Devel] [ramips] Linkit Smart 7688 kmod-sdhci-mt7620

Ivan Hörler ivanhoerler at gmail.com
Sat Sep 14 11:32:59 EDT 2019


Hi Adrian
Thanks for your patientness. Wasn’t aware it's so strict. I just added the --signedoff to the commit.
Good to know how to work clean. Now i redone it. 
Is this fullfilling openWRT’s rules? https://github.com/openwrt/openwrt/pull/2411
Regards, Ivan 

> Am 14.09.2019 um 16:27 schrieb Adrian Schmutzler <notifications at github.com>:
> 
> Hi, if you haven't yet, please have a look at https://openwrt.org/submitting-patches <https://openwrt.org/submitting-patches>
> Specifically, please
> 
> remove the two commits adding and removing the "wrong" version, so that only the correct commit survives (e.g. with git rebase -i @~3)
> add a "ramips: " prefix to your commit titles
> Your Signed-off-by has to contain a real name
> add a commit message describing what you change and why
>> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub <https://github.com/openwrt/openwrt/pull/2410?email_source=notifications&email_token=ABOOK6G3ZRCYYHUGPDDZGA3QJTYDRA5CNFSM4IWXBPP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6W4ZVQ#issuecomment-531483862>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABOOK6DBWEFJN6IA2OBL6BDQJTYDRANCNFSM4IWXBPPQ>.
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20190914/abd3d94c/attachment.htm>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list