[OpenWrt-Devel] [PATCH] libpcap: patch to add limits.h to pcap-usb-linux.c

[Michael Richardson]

Bjørn Mork <bjorn at mork.no> wrote:
    >> The reason why the buildservers don't fail is that they're probably
    >> not setting CONFIG_PCAP_HAS_USB (default is OFF), so the patched file
    >> does not get compiled.  I will add that info in the cover letter.

    > Not directly related.... But I wonder if maybe this default could be
    > changed?

    > I realize that this is a space thing, but having an optional feature
    > defaulting to off means that practically nobody uses the feature.  And
    > this one is particularily useful.  At least to me :-) Which of course
    > is no argument since I can easily build my own images with the feature
    > enabled.

I also agree, but turning in USB requires additional libraries, and I'm not
sure that many will need USB captures on openwrt.

I (as mcr at tcpdump.org) don't understand why you are seeing a build failure
that causes you to want to patch the file.

Also, the latest libpcap (1.9.0) has cmake support, which might make things
easier?

--
]               Never tell me the odds!                 | ipv6 mesh networks [
]   Michael Richardson, Sandelman Software Works        | network architect  [
]     mcr at sandelman.ca  http://www.sandelman.ca/        |   ruby on rails    [

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 487 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20180820/ae0cc202/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel