[OpenWrt-Devel] [PATCH] libpcap: patch to add limits.h to pcap-usb-linux.c

[Bjørn Mork]

Eneas Ulir de Queiroz via openwrt-devel
<openwrt-devel at lists.openwrt.org> writes:

> The reason why the buildservers don't fail is that they're probably
> not setting CONFIG_PCAP_HAS_USB (default is OFF), so the patched file
> does not get compiled.  I will add that info in the cover letter.

Not directly related.... But I wonder if maybe this default could be
changed?

I realize that this is a space thing, but having an optional feature
defaulting to off means that practically nobody uses the feature.  And
this one is particularily useful.  At least to me :-) Which of course is
no argument since I can easily build my own images with the feature
enabled.

The argument for changing the default is that it would make life a hell
of a lot easier for anyone doing USB driver development, saving quite a
few round-trip times trying to get USB captures from ordinary OpenWrt
end users. So I'd like to see CONFIG_PCAP_HAS_USB enabled
unconditionally, and rather have an optional libpcap-mini package with
less features if necessary.  Which I am not convinced it is....


Bjørn

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel