[OpenWrt-Devel] [PATCH 1/3] ar71xx: WNR612v2: exclude USB modules from image

[Felix Fietkau]

On 2016-02-26 21:36, Felix Fietkau wrote:
> On 2016-02-26 21:18, Michal wrote:
>> On Thu, 25 Feb 2016 14:27:56 +0100
>> Felix Fietkau <nbd at openwrt.org> wrote:
>> 
>>> On 2016-02-21 22:55, Michal wrote:
>>> > From: Michal Cieslakiewicz <michal.cieslakiewicz at wp.pl>
>>> > Date: Sun, 21 Feb 2016 18:17:27 +0100
>>> > Subject: [PATCH 1/3] ar71xx: WNR612v2: exclude USB modules from
>>> > image
>>> > 
>>> > Netgear WNR612v2 has no USB port yet default system image
>>> > includes USB kernel modules. This patch fixes that.
>>> > 
>>> > Signed-off-by: Michal Cieslakiewicz <michal.cieslakiewicz at wp.pl>
>>> > ---
>>> >  target/linux/ar71xx/generic/profiles/netgear.mk | 1 +
>>> >  1 file changed, 1 insertion(+)
>>> > 
>>> > diff --git a/target/linux/ar71xx/generic/profiles/netgear.mk
>>> > b/target/linux/ar71xx/generic/profiles/netgear.mk index
>>> > 2796e46..32c692a 100644 ---
>>> > a/target/linux/ar71xx/generic/profiles/netgear.mk +++
>>> > b/target/linux/ar71xx/generic/profiles/netgear.mk @@ -54,6 +54,7 @@
>>> > $(eval $(call Profile,WNR2000V4)) 
>>> >  define Profile/WNR612V2
>>> >  	NAME:=NETGEAR WNR612V2 / On Networks N150
>>> > +	PACKAGES:= -kmod-usb-core -kmod-usb-ohci -kmod-usb2
>>> > -kmod-ledtrig-usbdev  
>>> This doesn't make any sense to me. Those modules are not enabled in
>>> the target default package set, so it shouldn't be necessary for the
>>> profile to explicitly remove them.
>>> I don't see how this patch changes anything...
>>> 
>>> - Felix
>> 
>> Hello Felix,
>> 
>> I disagree, patch works as expected. If you remove PACKAGES line
>> completely, USB modules gets into image and its size increases (3407876
>> vs 3473412, tested on r48780).
>> 
>> Anyway, this topic seems concluded because patch mentioned here has
>> been included in recent trunk :-)
> It's not concluded for me. The patch is still wrong, because it papers
> over a bug instead of fixing it properly.
Found the real bug and fixed it in r48807
Reverted your patch in r48808

- Felix
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel