[OpenWrt-Devel] [PATCH] explicitely ignore return value of symlink(3) call

[Felix Fietkau]

On 2015-10-22 23:15, Daniel Golle wrote:
> glibc sets __attribute_warn_unused_result__ on symlink(3) if
> FORTIFY_SOURCE is set. This breaks procd which deliberately ignores
> the result of the symlink(3) call early during init as there wouldn't
> be anything better to do in that case other than ignoring the error and
> trying to survive.
> 
> Introduce libc-compat.h to work-around libc anomalities.
> 
> Signed-off-by: Daniel Golle <daniel at makrotopia.org>
> --- /dev/null
> +++ b/libc-compat.h
> @@ -0,0 +1,10 @@
> +#ifndef __PROCD_LIBC_COMPAT_H
> +#define __PROCD_LIBC_COMPAT_H
> +
> +#if defined(__GLIBC__) && !defined(__UCLIBC__)
> +static inline int ignore(int x) {return x;}
> +#else
> +#define ignore(x) x
> +#endif
This libc detection hackery looks completely useless to me.
Why did you add it?

- Felix
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel