[OpenWrt-Devel] [PATCH 2/2] ar71xx: add support for TP-LINK TL-WR841N/ND v10

[Matthias Schiffer]

No, LuCI uses util.ubus("system", "board"), which doesn't even expose
the internal board_name, but only the model name, so it will only see
the v10.

Automatic upgrade systems should also rely on the model name only, not
the board name.

The board name is really only an internal identifier. Reusing a board
name when new hardware has been released which is compatible with
another model is very common, just take a look at
target/linux/ar71xx/image/Makefile. There's a total of 7 models using
"TL-WR741ND", 5 models using "TL-WR741ND-v4" and another 5 using
"TL-WA901ND" as their BOARDNAME value...

Matthias


On 10/27/2015 02:50 AM, Alexander Couzens wrote:
> After taking some time to think about this.
> 
> Wouldn't luci tell the user it's running on a 841 v9?
> This could confuse them because a v9 sysupgrade wouldn't work.
> sysupgrade fails then. Also an automatic upgrade based on system info
> wouldn't work either.
> 
> As long we don't have dts support, I see here two solution. Add another
> mips machine or change the board detection to detect this difference.
> 
> Best,
> lynxis
> 
> On Mon, 26 Oct 2015 15:28:09 +0100
> Alexander Couzens <lynxis at fe80.eu> wrote:
> 
>> On Mon, 26 Oct 2015 01:21:58 +0100
>> Matthias Schiffer <mschiffer at universe-factory.net> wrote:
>>
>>> Thanks, but I know what I'm doing. The hardware is similar enough to
>>> boot with the exact same initialization routines as the v9, thus
>>> reusing the BOARDNAME is fine (it is done like this for other
>>> hardware as well - OpenWrt has a distinction between "board" and
>>> "model", where multiple models can have the same board, but still
>>> each model has its own images)
>>>
>>> On TP-LINK devices, sysupgrade checks the TPLINK_HWID of the image
>>> against the one in the flash, the BOARDNAME doesn't matter (except
>>> to determine that it is a TP-LINK device).  
>>
>> Sorry, no offensive. I forgot the tplink specific check within
>> sysupgrade.
> 
> 
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20151027/9b493327/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel