[OpenWrt-Devel] SVN to GIT transition

[Roman Yeryomin]

On 14 October 2015 at 00:20, David Lang <david at lang.hm> wrote:
> On Wed, 14 Oct 2015, Roman Yeryomin wrote:
>
>> On 13 October 2015 at 23:08, David Lang <david at lang.hm> wrote:
>>>
>>> On Tue, 13 Oct 2015, Roman Yeryomin wrote:
>>>
>>>>>
>>>>> Would it be possible to track the revision number in an automated way
>>>>> even
>>>>> in a git repo?  So store the r number, and automatically increment on
>>>>> commits.  Not sure if that's an option, but it seems like it might
>>>>> address
>>>>> the problem.
>>>>>
>>>>
>>>> If a user is smart enough to commit something locally then he knows
>>>> what he is doing and is smart enough to report the changes he made.
>>>> It's so simple.
>>>
>>>
>>>
>>> I think the concern is that someone may do this and then make the
>>> resulting
>>> images available to others to install.
>>
>>
>> Someone can do this (change the revision) very easily now too (and
>> this is good, because allows using internal revision numbers for
>> custom fw builders), so there is no way you can protect from this (I
>> would even say there is no point in protecting from this).
>
>
> I think it's a good idea to encourage other builders to have a unique id in
> there. That's why I was talking earlier about adding the initials of the
> builder to the version string.
>
> Even if they are compiling the same code, there are enough different ways to
> configure things that can cause problems that it's worth knowing if it's a
> stock build or a custom one.

You can put any initials (or other info) into your version number or
other configurable identifiers, but, IMO, forcing this is a bad idea.

Regards,
Roman
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel