[OpenWrt-Devel] [PATCH 1/2] lantiq: fix ath_pci_fixup hang on bridged devices

[Mathias Kresin]

Port of r41856.

In contrast to the brcm63xx target, it isn't sufficient to enable/disable
the bridge. The device needs to be enabled/disabled to fix the hang. The
bridge will be automatically enabled by the time the connected device is
enabled.

Fixes boot on TD-W8980.

Signed-off-by: Mathias Kresin <openwrt at kresin.me>
Signed-off-by: Martin Blumenstingl <martin.blumenstingl at googlemail.com>
---
 .../0035-owrt-lantiq-wifi-and-ethernet-eeprom-handling.patch  | 11 ++++++++++-
 .../0035-owrt-lantiq-wifi-and-ethernet-eeprom-handling.patch  | 11 ++++++++++-
 2 files changed, 20 insertions(+), 2 deletions(-)

diff --git a/target/linux/lantiq/patches-3.18/0035-owrt-lantiq-wifi-and-ethernet-eeprom-handling.patch b/target/linux/lantiq/patches-3.18/0035-owrt-lantiq-wifi-and-ethernet-eeprom-handling.patch
index ec769ccf..2fc4db3 100644
--- a/target/linux/lantiq/patches-3.18/0035-owrt-lantiq-wifi-and-ethernet-eeprom-handling.patch
+++ b/target/linux/lantiq/patches-3.18/0035-owrt-lantiq-wifi-and-ethernet-eeprom-handling.patch
@@ -415,7 +415,7 @@ Signed-off-by: John Crispin <blogic at openwrt.org>
 +device_initcall(of_eth_mac_init);
 --- /dev/null
 +++ b/arch/mips/lantiq/xway/pci-ath-fixup.c
-@@ -0,0 +1,109 @@
+@@ -0,0 +1,118 @@
 +/*
 + *  Atheros AP94 reference board PCI initialization
 + *
@@ -442,6 +442,7 @@ Signed-off-by: John Crispin <blogic at openwrt.org>
 +static void ath_pci_fixup(struct pci_dev *dev)
 +{
 +	void __iomem *mem;
++	struct pci_dev *bridge = pci_upstream_bridge(dev); 
 +	u16 *cal_data = NULL;
 +	u16 cmd;
 +	u32 bar0;
@@ -477,6 +478,10 @@ Signed-off-by: John Crispin <blogic at openwrt.org>
 +		return;
 +	}
 +
++	if (bridge) {
++		pci_enable_device(dev);
++	}
++
 +	pci_read_config_dword(dev, PCI_BASE_ADDRESS_0, &bar0);
 +	pci_write_config_dword(dev, PCI_BASE_ADDRESS_0, base);
 +	pci_read_config_word(dev, PCI_COMMAND, &cmd);
@@ -512,6 +517,10 @@ Signed-off-by: John Crispin <blogic at openwrt.org>
 +
 +	pci_write_config_dword(dev, PCI_BASE_ADDRESS_0, bar0);
 +
++	if (bridge) {
++		pci_disable_device(dev);
++	}
++
 +	iounmap(mem);
 +}
 +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_ATHEROS, PCI_ANY_ID, ath_pci_fixup);
diff --git a/target/linux/lantiq/patches-4.1/0035-owrt-lantiq-wifi-and-ethernet-eeprom-handling.patch b/target/linux/lantiq/patches-4.1/0035-owrt-lantiq-wifi-and-ethernet-eeprom-handling.patch
index 72ae1c9..6d53cd9 100644
--- a/target/linux/lantiq/patches-4.1/0035-owrt-lantiq-wifi-and-ethernet-eeprom-handling.patch
+++ b/target/linux/lantiq/patches-4.1/0035-owrt-lantiq-wifi-and-ethernet-eeprom-handling.patch
@@ -415,7 +415,7 @@ Signed-off-by: John Crispin <blogic at openwrt.org>
 +device_initcall(of_eth_mac_init);
 --- /dev/null
 +++ b/arch/mips/lantiq/xway/pci-ath-fixup.c
-@@ -0,0 +1,109 @@
+@@ -0,0 +1,118 @@
 +/*
 + *  Atheros AP94 reference board PCI initialization
 + *
@@ -442,6 +442,7 @@ Signed-off-by: John Crispin <blogic at openwrt.org>
 +static void ath_pci_fixup(struct pci_dev *dev)
 +{
 +	void __iomem *mem;
++	struct pci_dev *bridge = pci_upstream_bridge(dev); 
 +	u16 *cal_data = NULL;
 +	u16 cmd;
 +	u32 bar0;
@@ -477,6 +478,10 @@ Signed-off-by: John Crispin <blogic at openwrt.org>
 +		return;
 +	}
 +
++	if (bridge) {
++		pci_enable_device(dev);
++	}
++
 +	pci_read_config_dword(dev, PCI_BASE_ADDRESS_0, &bar0);
 +	pci_write_config_dword(dev, PCI_BASE_ADDRESS_0, base);
 +	pci_read_config_word(dev, PCI_COMMAND, &cmd);
@@ -512,6 +517,10 @@ Signed-off-by: John Crispin <blogic at openwrt.org>
 +
 +	pci_write_config_dword(dev, PCI_BASE_ADDRESS_0, bar0);
 +
++	if (bridge) {
++		pci_disable_device(dev);
++	}
++
 +	iounmap(mem);
 +}
 +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_ATHEROS, PCI_ANY_ID, ath_pci_fixup);
-- 
1.9.1
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel