[OpenWrt-Devel] [RFC] [PATCH] build: honor command line CONFIG_ variables on kernel_*config targets

[Felix Fietkau]

Please don't send HTML mails to the list, further comment below.

On 2015-05-13 15:11, Emmanuel Deloget wrote:
> The CONFIG_* variables are correctly handled when building nearly all
> targets (at least packages and full build) yet they are not honored on 
> kernel_menuconfig and similar targets.
> 
> Some use case :
> 
>   make CONFIG_DOWNLOAD_FOLDER=../dl/ kernel_menuconfig
>   make CONFIG_BUILD_SUFFIX=test kernel_oldconfig
> 
> and so on...
> 
> When used, they generate build errors because the kernel_*config targets
> are not able to find the correct directories.
> 
> Signed-off-by: Emmanuel Deloget <emmanuel at deloget.com
> <mailto:emmanuel at deloget.com>>
> ---
>  include/toplevel.mk <http://toplevel.mk> | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/toplevel.mk <http://toplevel.mk>
> b/include/toplevel.mk <http://toplevel.mk>
> index d8651d9..02e337a 100644
> --- a/include/toplevel.mk <http://toplevel.mk>
> +++ b/include/toplevel.mk <http://toplevel.mk>
> @@ -128,13 +128,13 @@ else
>  endif
>  
>  kernel_oldconfig: prepare_kernel_conf
> -$(_SINGLE)$(NO_TRACE_MAKE) -C target/linux oldconfig
> +$(_SINGLE)$(NO_TRACE_MAKE) $(filter CONFIG_%,$(MAKEFLAGS)) -C
> target/linux oldconfig
I think this is the wrong approach, filtering only CONFIG_* variables is
overly specific. The issue with this target is that $(_SINGLE) overrides
MAKEFLAGS.
Please try adding -j1 to the make command line, removing $(_SINGLE).

- Felix
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel