[OpenWrt-Devel] [RFC] [PATCH] build: honor command line CONFIG_ variables on kernel_*config targets

Emmanuel Deloget logout at free.fr
Wed May 13 09:11:14 EDT 2015


The CONFIG_* variables are correctly handled when building nearly all
targets (at least packages and full build) yet they are not honored on
kernel_menuconfig and similar targets.

Some use case :

  make CONFIG_DOWNLOAD_FOLDER=../dl/ kernel_menuconfig
  make CONFIG_BUILD_SUFFIX=test kernel_oldconfig

and so on...

When used, they generate build errors because the kernel_*config targets
are not able to find the correct directories.

Signed-off-by: Emmanuel Deloget <emmanuel at deloget.com>
---
 include/toplevel.mk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/toplevel.mk b/include/toplevel.mk
index d8651d9..02e337a 100644
--- a/include/toplevel.mk
+++ b/include/toplevel.mk
@@ -128,13 +128,13 @@ else
 endif

 kernel_oldconfig: prepare_kernel_conf
- $(_SINGLE)$(NO_TRACE_MAKE) -C target/linux oldconfig
+ $(_SINGLE)$(NO_TRACE_MAKE) $(filter CONFIG_%,$(MAKEFLAGS)) -C
target/linux oldconfig

 kernel_menuconfig: prepare_kernel_conf
- $(_SINGLE)$(NO_TRACE_MAKE) -C target/linux menuconfig
+ $(_SINGLE)$(NO_TRACE_MAKE) $(filter CONFIG_%,$(MAKEFLAGS)) -C
target/linux menuconfig

 kernel_nconfig: prepare_kernel_conf
- $(_SINGLE)$(NO_TRACE_MAKE) -C target/linux nconfig
+ $(_SINGLE)$(NO_TRACE_MAKE) $(filter CONFIG_%,$(MAKEFLAGS)) -C
target/linux nconfig

 staging_dir/host/.prereq-build: include/prereq-build.mk
  mkdir -p tmp
-- 
2.1.4
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20150513/9c29777f/attachment.htm>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list