[OpenWrt-Devel] [PATCH 00/13] ramips: massive code cleanups

Piotr Dymacz pepe2k at gmail.com
Thu Jul 30 09:38:53 EDT 2015


2015-07-30 14:24 GMT+02:00 John Crispin <blogic at openwrt.org>:
[...]

> big diff stat. i like it. can you do the same for lantiq ? :)

Maybe... and ar71xx too? ;)

> i will stop merging new board to ramips target untilt his series is in
> the tree to save you having to rebase too often.

OK.

> when can we expect a v2 ?

There was a discussion about upstream LED naming convention and this patch:
[PATCH 05/13] ramips: use consistent naming scheme for LEDs, for
various manufacturers

I sent my idea about diag.sh and 01_leds scripts optimization, but it
hasn't got any positive or negative feedback yet... so I decided to
wait.

I want to reorder my patches in v2 series (move other small changes in
the front of that LED naming related stuff, so eventually they can be
omitted without breaking other changes).
I should be able to prepare v2 during the weekend.

> how do you create the patch ? i am a bit worried that c&p bugs or similar can sneak in.

In some cases by hand... in other, using available tools (sed, awk,
grep, git grep etc.).

My original series contained more than 30 patches (one change = one
commit) and I verified every single one.
I merged logically related commits into one change before sending whole series.

I hope I didn't make more bugs than I'm trying to fix.

Piotr
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list