[OpenWrt-Devel] [PATCH 05/13] ramips: use consistent naming scheme for LEDs, for various manufacturers

Piotr Dymacz pepe2k at gmail.com
Sun Jul 26 15:34:51 EDT 2015


2015-07-26 21:16 GMT+02:00 Imre Kaloz <kaloz at openwrt.org>:
>
> On Sun, 26 Jul 2015 18:24:30 +0200, Piotr Dymacz <pepe2k at gmail.com> wrote:
>
>> For some boards in ramips (and other targets) naming scheme for LEDs is:
>> "manufacturer:color:led-name", but there are many other boards which don't
>> follow this approach.
>
>
> The upstream convention is "device:color:led-name". So actually, the wrong way is where we do the other way around.

That's bad news... I will fix it.
But, why then patches with wrong convention are still accepted?

Examples:
https://dev.openwrt.org/changeset/46248
https://dev.openwrt.org/changeset/46349
https://dev.openwrt.org/changeset/46444
https://dev.openwrt.org/changeset/46454
https://dev.openwrt.org/changeset/46458

And, when the convention was changed?

Piotr
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list