[OpenWrt-Devel] [PATCH] ramips mt7620: ArcherC20i USB support and more

[Jonas Gorski]

Hi,

On Mon, Jul 6, 2015 at 11:56 PM, Gunnar Thorburn <gunnar at thorburn.se> wrote:
> Hi,
>
> The patch (actually the entire file) was contributed on the OpenWrt forum:
> https://forum.openwrt.org/viewtopic.php?pid=281794#p281794
> My contribution is that I have tested it and that I am trying to submit it
> here.
>
> I can confirm that:
>  1) My ArcherC20i works fine with the patch applied
>  2) USB works (which it does not do in CC without the patch)
>
> If the changes not related to USB (ehci/ohci) are questionable, I would be
> happy to resubmit a patch for just USB. I am sorry about the spaces and
> tabs. The clean patch below looks much nicer.

I'm mostly looking for a description what this patch does. You already
mentioned enabling USB in the subject, but you should also mention the
buttons/leds. Please write a commit log as you would write a commit,
without any "hello" and 'byes". And finally you dropped your
sign-off-by.

>
>   Gunnar T.
>
>
> $ diff -up target/linux/ramips/dts/ArcherC20i.dts{.orig,}
> --- target/linux/ramips/dts/ArcherC20i.dts.orig 2015-07-05
> 15:27:04.763421748 +0200
> +++ target/linux/ramips/dts/ArcherC20i.dts      2015-07-06
> 23:11:04.533094775 +0200
> @@ -15,6 +15,10 @@
>                         status = "okay";
>                 };
>

Your email-client ate the spaces at the start of empty context lines,
this patch is broken.

> +                               gpio3: gpio at 688 {
> +                                               status = "okay";
> +                               };
> +

Wrong indentation.

>                 spi at b00 {
>                         status = "okay";
>
> @@ -77,8 +81,12 @@
>                 ralink,port-map = "wllll";
>         };
>
> -       gsw at 10110000 {
> -               ralink,port4 = "ephy";

Why are you removing this part?

> +       ehci at 101c0000 {
> +               status = "okay";
> +       };
> +
> +       ohci at 101c1000 {
> +               status = "okay";
>         };
>
>         wmac at 10180000 {
> @@ -100,6 +108,18 @@
>
>         gpio-leds {
>                 compatible = "gpio-leds";

Empty line here please.

> +                               lan {
> +                                               label = "tp-link:blue:lan";
> +                                               gpios = <&gpio0 1 1>;
> +                               };

Wrong indentation. Also empty line here please.

> +               usb {
> +                       label = "tp-link:blue:usb";
> +                       gpios = <&gpio0 11 1>;
> +               };

Empty line here please.

> +                               wlan {
> +                                               label = "tp-link:blue:wlan";
> +                                               gpios = <&gpio3 0 1>;
> +                               };

Wrong indentation.

>         };
>
>         gpio-keys-polled {
> @@ -107,5 +127,15 @@
>                 #address-cells = <1>;
>                 #size-cells = <0>;
>                 poll-interval = <20>;

Empty line here please.

> +               reset_wps {
> +                       label = "reset_wps";
> +                       gpios = <&gpio0 13 1>;
> +                       linux,code = <0x198>;
> +               };

Empty line here please.

> +               rfkill {
> +                       label = "rfkill";
> +                       gpios = <&gpio0 2 1>;
> +                       linux,code = <0xf7>;
> +               };
>         };
>  };
>

Please fix and resend.


Jonas
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel