[OpenWrt-Devel] [PATCH 3/3] ipq806x: add ap148 bootargs to DT

[Imre Kaloz]

On Thu, 19 Feb 2015 02:01:14 +0100, Mathieu Olivari  
<mathieu at codeaurora.org> wrote:

> This will simplify the boot process by avoiding the bootloader
> bootargs configuration process.
>
> Signed-off-by: Mathieu Olivari <mathieu at codeaurora.org>
> ---

...

> ++	chosen {
> ++		bootargs = "console=ttyMSM0,115200 root=/dev/mtdblock12  
> rootfstype=squashfs,jffs2";
> ++	};
> ++
> + 	soc {
> + 		pinmux at 800000 {
> + 			i2c4_pins: i2c4_pinmux {

There's no need to specify the root partition if you follow "the OpenWrt  
way" :)

> +@@ -70,13 +74,68 @@
> + 					reg = <0>;
> +
> + 					partition at 0 {
> +-						label = "rootfs";
> +-						reg = <0x0 0x1000000>;
> ++						label = "0:SBL1";
> ++						reg = <0x0 0x20000>;
> + 					};
> +
> + 					partition at 1 {
> +-						label = "scratch";
> +-						reg = <0x1000000 0x1000000>;
> ++						label = "0:MIBIB";
> ++						reg = <0x20000 0x20000>;
> ++					};
> ++
> ++					partition at 2 {
> ++						label = "0:SBL2";
> ++						reg = <0x40000 0x40000>;
> ++					};
> ++
> ++					partition at 3 {
> ++						label = "0:DDR";
> ++						reg = <0x80000 0x10000>;
> ++					};
> ++
> ++					partition at 4 {
> ++						label = "0:DDRCONFIG";
> ++						reg = <0x90000 0x10000>;
> ++					};
> ++
> ++					partition at 5 {
> ++						label = "0:SSD";
> ++						reg = <0xa0000 0x10000>;
> ++					};
> ++
> ++					partition at 6 {
> ++						label = "0:TZ";
> ++						reg = <0xb0000 0x80000>;
> ++					};
> ++
> ++					partition at 7 {
> ++						label = "0:RPM";
> ++						reg = <0x130000 0x80000>;
> ++					};
> ++
> ++					partition at 8 {
> ++						label = "0:APSSBL";
> ++						reg = <0x1b0000 0x80000>;
> ++					};
> ++
> ++					partition at 9 {
> ++						label = "0:APSSBLENV";
> ++						reg = <0x230000 0x40000>;
> ++					};
> ++
> ++					partition at a {
> ++						label = "0:ART";
> ++						reg = <0x270000 0x40000>;
> ++					};
> ++
> ++					partition at b {
> ++						label = "0:HLOS";
> ++						reg = <0x2b0000 0x300000>;
> ++					};
> ++
> ++					partition at c {
> ++						label = "rootfs";
> ++						reg = <0x5b0000 0x1a50000>;
> + 					};
> + 				};
> + 			};

Well, first of all this should be part of a separate patch. Second,  
although the original partition definition seems weird a bit, this new one  
is... well, pretty close to being unacceptable. What are these partitions?  
 From where are you loading the kernel?


Imre
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel