[OpenWrt-Devel] [PATCH v3] bcm63xx: add Comtrend VR-3026e support

[Martin Tesar]

Hi,

it's just a cosmetic change. Now I understand I shouldn't do that.
Should I create a new patch?

Regards,
Martin

27. 8. 2015 v 11:23, Jonas Gorski <jogo at openwrt.org>:

>> On Wed, Aug 26, 2015 at 7:18 PM, Martin Tesar <tesarmar at gmail.com> wrote:
>> Add support for Comtrend VR-3026e v1.
>> The device is almost identical to the Comtrend VR-3025un.
>> 
>> Signed-off-by: Martin Tesar <tesarmar at gmail.com>
>> ---
>> target/linux/brcm63xx/base-files/etc/diag.sh       |  3 +
>> .../base-files/etc/uci-defaults/02_network         |  3 +-
>> .../base-files/etc/uci-defaults/09_fix_crc         |  1 +
>> target/linux/brcm63xx/base-files/lib/brcm63xx.sh   |  3 +
>> .../lib/preinit/05_init_interfaces_brcm63xx        |  1 +
>> target/linux/brcm63xx/dts/vr-3026e.dts             | 88 ++++++++++++++++++++++
>> target/linux/brcm63xx/image/Makefile               |  2 +
>> .../brcm63xx/patches-3.18/572-board_VR-3026e.patch | 79 +++++++++++++++++++
>> .../brcm63xx/patches-4.1/572-board_VR-3026e.patch  | 79 +++++++++++++++++++
>> target/linux/brcm63xx/profiles/comtrend.mk         |  9 +++
>> 10 files changed, 267 insertions(+), 1 deletion(-)
>> create mode 100644 target/linux/brcm63xx/dts/vr-3026e.dts
>> create mode 100644 target/linux/brcm63xx/patches-3.18/572-board_VR-3026e.patch
>> create mode 100644 target/linux/brcm63xx/patches-4.1/572-board_VR-3026e.patch
>> 
>> diff --git a/target/linux/brcm63xx/base-files/etc/diag.sh b/target/linux/brcm63xx/base-files/etc/diag.sh
>> index 7916ac2..7826fad 100644
>> --- a/target/linux/brcm63xx/base-files/etc/diag.sh
>> +++ b/target/linux/brcm63xx/base-files/etc/diag.sh
>> @@ -39,6 +39,9 @@ set_state() {
>>        vr-3025u)
>>                status_led="VR-3025u:green:power"
>>                ;;
>> +       vr-3026e)
>> +               status_led="VR-3026e:green:power"
>> +               ;;
>>        wap-5813n)
>>                status_led="WAP-5813n:green:power"
>>                ;;
>> diff --git a/target/linux/brcm63xx/base-files/etc/uci-defaults/02_network b/target/linux/brcm63xx/base-files/etc/uci-defaults/02_network
>> index 2ff9e45..4de861c 100644
>> --- a/target/linux/brcm63xx/base-files/etc/uci-defaults/02_network
>> +++ b/target/linux/brcm63xx/base-files/etc/uci-defaults/02_network
>> @@ -94,8 +94,9 @@ fast2504n |\
>> fast2704v2 |\
>> hg655b |\
>> p870hw-51a_v2 |\
>> +vr-3025u |\
>> vr-3025un |\
>> -vr-3025u)
>> +vr-3026e)
> 
> Why did you change the order of vr-3025u and vr-3025un here? You
> didn't do this in your previous versions. Please do not add random
> cleanups/changes to your patches.
> 
> 
> Jonas
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel