[PATCH 2/3] ath10k: Grab rcu_read_lock before the txqs spinlock.
Manoharan, Rajkumar
rmanohar at qti.qualcomm.com
Thu Aug 18 20:01:14 PDT 2016
> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
> index 916119c..d96c06e 100644
> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -4307,8 +4307,8 @@ void ath10k_mac_tx_push_pending(struct ath10k *ar)
> int max;
> int loop_max = 2000;
>
> - spin_lock_bh(&ar->txqs_lock);
> rcu_read_lock();
> + spin_lock_bh(&ar->txqs_lock);
>
Ben,
It is quite possible that push_pending can be preempted after acquiring rcu_lock which
may lead to deadlock. no? I assume to prevent that spin_lock is taken first.
Could you please explain how this reordering is fixing dead lock?
-Rajkumar
More information about the ath10k
mailing list