[PATCH] firmware-utils: tplink-safeloader: Add support for Deco M4R V4

Shiz hi at shiz.me
Sat Jan 28 09:19:42 PST 2023


Hi Sander,

Thanks for reviewing my patch!

> On 28 Jan Reiwa 5, at 17:09, Sander Vanheule <sander at svanheule.net> wrote:
> 
> Hi Mark,
> 
> On Sun, 2023-01-22 at 12:46 +0100, Mark Ceeha wrote:
>> Software version:
>> soft_ver:1.0.3 Build 20220426 Rel. 32976
> 
> I assume this is the FW image you've based this on?

My bad, this is the firmware version of the M4R that I upgraded;
this patch was based on the following firmware image:

  soft_ver:1.0.2 Build 20220401 Rel. 35920

I just cross-referenced and confirmed it to match with the following
initial firmware version I hadn't found before:

  soft_ver:1.0.0 Build 20211202 Rel. 69482

If preferred, I can include that version in the commit message instead.

>> [...]
> 
> Please leave an empty line between devices.

ACK.

>> [...]
> 
> This is different from the version above. Does the device require this version
> as a lower bound? Normally, usage of SOFT_VER_DEFAULT is preferred.

As it was the version of the firmware image I researched,
which is the initial firmware release, I figured it was a safe lower bound.

TP-Link's own firmware expects it to be in the _TEXT format and >= current version
to allow the upgrade, but U-Boot does not care.

>> [...]
> 
> Please use alphabetical sorting and put "DECO-M4R-V4" after "ARCHER-C6-V3".

ACK.

> Best,
> Sander

Feel free let let me know how you'd like the soft_ver to be handled,
and I'll submit a v2.

Kind regards,
Shiz


More information about the openwrt-devel mailing list