[PATCH] iwinfo: devices: add Qualcomm Atheros IPQ8074 WiSoC

Robert Marko robimarko at gmail.com
Sat Jan 7 13:43:04 PST 2023

On Fri, 6 Jan 2023 at 23:43, Jo-Philipp Wich <jo at mein.io> wrote:
> Hi Robert,
> I know that you're just expanding existing code (which I recently noticed for
> the first time) but I think that adding more and more if/else clauses with
> further hardware matches for purely cosmetic reasons* is a good way forward.
> At the very least a mechanism should be added to configure this
> FDT-to-PCI-ID-to-name mapping in the devices.txt file directly.
> *) Many hardware entries are simply added to show a fancy radio name instead
>    of "Generic MAC80211" radio but don't add non-defaults values such as power
>    offsets or antenna gains.

Jo, I agree that adding more if/else isn't ideal but this is pretty
much what has been
done so far and I dont have time or ideas on how to improve this.

And yeah, devices are added just to display the SoC name instead of the generic
name and that's pretty much it.

> Regards,
> Jo
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel

More information about the openwrt-devel mailing list