[PATCH] iwinfo: devices: add Qualcomm Atheros IPQ8074 WiSoC

Christian Marangi ansuelsmth at gmail.com
Fri Jan 6 16:49:13 PST 2023


On Fri, Jan 06, 2023 at 11:42:46PM +0100, Jo-Philipp Wich wrote:
> Hi Robert,
> 
> I know that you're just expanding existing code (which I recently noticed for
> the first time) but I think that adding more and more if/else clauses with
> further hardware matches for purely cosmetic reasons* is a good way forward.
> 
> At the very least a mechanism should be added to configure this
> FDT-to-PCI-ID-to-name mapping in the devices.txt file directly.
> 
> 
> *) Many hardware entries are simply added to show a fancy radio name instead
>    of "Generic MAC80211" radio but don't add non-defaults values such as power
>    offsets or antenna gains.
> 
> 

Just to make sure I got this right. The idea here is to drop the
function for the compatible parsing and add some kind support for it
directly in devices.txt? 

Would an additional column to devices.txt enough for this?
And enforce subsystem and device_id to 0xffff to fallback to compatible
matching in this specific case?

Can't see any other simple way for it than adding an entire new column
to the file and hardcode the other values to select this particular
mode.

I wonder if a good idea would be use another type of format... like a
JSON and convert the txt to it? Would make the thing much easier to handle.

-- 
	Ansuel



More information about the openwrt-devel mailing list