[PATCH v3 0/5] bcm53xx: Support D-Link DIR-890L

Felix Baumann felix.baumann at freifunk-aachen.de
Tue Aug 1 01:16:27 PDT 2023

Am 1. August 2023 08:51:03 MESZ schrieb "Bjørn Mork" <bjorn at mork.no>:
>Linus Walleij <linus.walleij at linaro.org> writes:
>>  can also create a pull request on github if it helps?
>Probably not.  There's a "6 approving reviews" rule on github, and not
>even close to that many active reviewers.  Sp adding new devices via
>pull requests seems impossible at the moment.
>openwrt-devel mailing list
>openwrt-devel at lists.openwrt.org

That is just an arbitrary number (probably to prevent accidental merges or so).
Most device PRs seem to be merged by Hauke.
But not all of them.
You don't need 6 reviews. But it helps when you have others that are able to test your code change and confirm that it works. (that won't happen much on adding new devices though)

But I agree that opening a PR on GitHub won't move this along. I guess, you can mostly revive the patch series by reminding people. Or ask them on IRC for review.

The overall problem is that not all patches are being looked at immediately and then they are being forgotten about. Not enough reviewers, yes. :/

I added some people to CC, that might be able to take a look at this. (mostly because I know that they are working with broadcom devices)

Also sorry, I butchered your names, my mail program (K9) doesn't support non-ascii characters. (so dumb)


More information about the openwrt-devel mailing list