[PATCH v3 0/5] bcm53xx: Support D-Link DIR-890L

Petr Štetiar ynezz at true.cz
Tue Aug 1 00:50:46 PDT 2023

Bjørn Mork <bjorn at mork.no> [2023-08-01 08:51:03]:


> Linus Walleij <linus.walleij at linaro.org> writes:
> >  can also create a pull request on github if it helps?
> Probably not. 

BTW I'm doing both, mailing list to notify first pair of eyes not following GH
closely, and PRs on GH to get another review attention and mainly to be
somehow sure, that I don't introduce regressions as there is quite heavy CI

> There's a "6 approving reviews" rule on github, and not
> even close to that many active reviewers.  Sp adding new devices via
> pull requests seems impossible at the moment.

Thats done on purpose, due to the current git.openwrt.org based workflow,
basically to prevent accidental merging via GH as this would break Git
repository sync. AFAIK GH simply doesn't allow us to disable those merge
buttons, so this is our workaround.



More information about the openwrt-devel mailing list