[PATCH v3 1/3] ramips: mt7621-dts: fix switch at 1f warnings

Arınç ÜNAL arinc.unal at arinc9.com
Sun Feb 13 05:06:42 PST 2022


On 13/02/2022 15:39, Sander Vanheule wrote:
> Hi Arınç,
> 
> On Sun, 2022-02-13 at 11:15 +0300, Arınç ÜNAL wrote:
>> Remove reg property from ports node to fix this warning:
>>
>> Warning (unit_address_vs_reg): /ethernet at 1e100000/mdio-bus/switch at 1f/ports: node has a
>> reg or ranges property, but no unit name
>>
>> Another warning surfaces afterwards. Remove #address-cells and #size-cells
>> from switch at 1f node to fix this warning:
>>
>> Warning (avoid_unnecessary_addr_size): /ethernet at 1e100000/mdio-bus/switch at 1f:
>> unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
>>
>> Signed-off-by: Arınç ÜNAL <arinc.unal at arinc9.com>
> 
> These changes make sense, and the Documentation/devicetree/bindings/net/dsa/dsa.yaml
> specifies it this way, but they don't conform to the (older) mt7530.txt binding. Have you
> considered converting the mt7530 binding to YAML and submitting it upstream? Then you
> could have proper validation of devicetrees with mt7530 :-)

That's actually on my task list! I'm reading around YAML and looking at 
the examples in the meantime.



More information about the openwrt-devel mailing list