[PATCH v3 1/3] ramips: mt7621-dts: fix switch at 1f warnings

[Sander Vanheule]

Hi Arınç,

On Sun, 2022-02-13 at 11:15 +0300, Arınç ÜNAL wrote:
> Remove reg property from ports node to fix this warning:
> 
> Warning (unit_address_vs_reg): /ethernet at 1e100000/mdio-bus/switch at 1f/ports: node has a
> reg or ranges property, but no unit name
> 
> Another warning surfaces afterwards. Remove #address-cells and #size-cells
> from switch at 1f node to fix this warning:
> 
> Warning (avoid_unnecessary_addr_size): /ethernet at 1e100000/mdio-bus/switch at 1f:
> unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
> 
> Signed-off-by: Arınç ÜNAL <arinc.unal at arinc9.com>

These changes make sense, and the Documentation/devicetree/bindings/net/dsa/dsa.yaml
specifies it this way, but they don't conform to the (older) mt7530.txt binding. Have you
considered converting the mt7530 binding to YAML and submitting it upstream? Then you
could have proper validation of devicetrees with mt7530 :-)

Best,
Sander

> ---
>  target/linux/ramips/dts/mt7621.dtsi | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/target/linux/ramips/dts/mt7621.dtsi b/target/linux/ramips/dts/mt7621.dtsi
> index b784a9d60c..ec95223a62 100644
> --- a/target/linux/ramips/dts/mt7621.dtsi
> +++ b/target/linux/ramips/dts/mt7621.dtsi
> @@ -481,8 +481,6 @@
>  
>                         switch0: switch at 1f {
>                                 compatible = "mediatek,mt7621";
> -                               #address-cells = <1>;
> -                               #size-cells = <0>;
>                                 reg = <0x1f>;
>                                 mediatek,mcm;
>                                 resets = <&rstctrl 2>;
> @@ -494,7 +492,6 @@
>                                 ports {
>                                         #address-cells = <1>;
>                                         #size-cells = <0>;
> -                                       reg = <0>;
>  
>                                         port at 0 {
>                                                 status = "disabled";