[OpenWrt-Devel] [PATCH] ath79: archer-c7-v5: fix initramfs image

[Baptiste Jonglez]

On 19-06-20, Petr Štetiar wrote:
> > On 17-06-20, Petr Štetiar wrote:
> > > Currently it's not possible to tftpboot initramfs image as the image
> > > contains tplink-v1-header which leads to:
> > 
> > Out of curiosity, it looks like booting an initramfs image is only
> > possible with serial access to the bootloader?
> 
> indeed, my use case is CI automatic testing with labgrid, so I don't want to
> trash my flash. In probably weekly CI job I plan to write factory image and
> perform sysupgrade in order to test those images as well.

Interesting! https://github.com/labgrid-project/labgrid

> > This is strange, Device/tplink-safeloader-uimage already defines KERNEL
> > the same way:
> > 
> >   KERNEL := kernel-bin | append-dtb | lzma | uImageArcher lzma
> > 
> > AFAIK, KERNEL_INITRAMFS should default to the same value as KERNEL.
> 
> Indeed, but Device/tplink-v1 redefines that to:
> 
>  KERNEL_INITRAMFS := kernel-bin | append-dtb | lzma | tplink-v1-header
> 
> and Device/tplink-safeloader-uimage inherits from Device/tplink-v1, reusing
> that KERNEL_INITRAMFS variable.

Ah, right, didn't spot that.  It means that other boards using
Device/tplink-safeloader-uimage likely have the same issue.

> Thanks for the review, going to send hopefully proper patch in a moment.
> 
> -- ynezz
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20200619/5c338262/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel