[OpenWrt-Devel] [PATCH] ath79: archer-c7-v5: fix initramfs image

[Petr Štetiar]

Baptiste Jonglez <baptiste at bitsofnetworks.org> [2020-06-19 10:22:57]:

Hi,

> On 17-06-20, Petr Štetiar wrote:
> > Currently it's not possible to tftpboot initramfs image as the image
> > contains tplink-v1-header which leads to:
> 
> Out of curiosity, it looks like booting an initramfs image is only
> possible with serial access to the bootloader?

indeed, my use case is CI automatic testing with labgrid, so I don't want to
trash my flash. In probably weekly CI job I plan to write factory image and
perform sysupgrade in order to test those images as well.

> > --- a/target/linux/ath79/image/generic-tp-link.mk
> > +++ b/target/linux/ath79/image/generic-tp-link.mk
> > @@ -197,6 +197,7 @@ define Device/tplink_archer-c7-v5
> >    TPLINK_BOARD_ID := ARCHER-C7-V5
> >    BOARDNAME := ARCHER-C7-V5
> >    SUPPORTED_DEVICES += archer-c7-v5
> > +  KERNEL_INITRAMFS := kernel-bin | append-dtb | lzma | uImageArcher lzma
> >  endef
> >  TARGET_DEVICES += tplink_archer-c7-v5
> 
> This is strange, Device/tplink-safeloader-uimage already defines KERNEL
> the same way:
> 
>   KERNEL := kernel-bin | append-dtb | lzma | uImageArcher lzma
> 
> AFAIK, KERNEL_INITRAMFS should default to the same value as KERNEL.

Indeed, but Device/tplink-v1 redefines that to:

 KERNEL_INITRAMFS := kernel-bin | append-dtb | lzma | tplink-v1-header

and Device/tplink-safeloader-uimage inherits from Device/tplink-v1, reusing
that KERNEL_INITRAMFS variable.

Thanks for the review, going to send hopefully proper patch in a moment.

-- ynezz

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel