[RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

Jo-Philipp Wich jo at mein.io
Thu Jul 23 08:28:11 EDT 2020

Hi again,

> What about spelling out the dependency explicitly? Instead of overloading the
> meaning of "option network", add an "option bridge" instead which reuses the
> existing vlan notation followed by a vlan id spec as defined by the "option
> ports" notation for bridge devices, e.g.

That should have read:

Add an option bridge that specifies the target bridge name and an option vlan
which contains vlan id, followed by the tag/untag/pvid spec as defined for
bridge ports.

Also a fourth example:

option bridge switch0
option vlan 20  # is equivalent to 20:u*

Since setting a non-default untagged pvid is by far the most (and likely only
sensible) use case for wifi-ifaces, specifying a vlan id without any suffix
should be supported as well. So `N` should be equivalent to `N:u*` or `N:*`.

~ Jo

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20200723/ef0f6600/attachment-0001.sig>

More information about the openwrt-devel mailing list