[RFC PATCH 3/5] image-commands: support Chromium OS image-type creation

[Brian Norris]

Hi Adrian,

On Sat, Jul 18, 2020 at 2:14 PM <mail at adrianschmutzler.de> wrote:
> > -----Original Message-----
> > From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> > On Behalf Of Brian Norris
> > Sent: Samstag, 18. Juli 2020 22:52
> > To: openwrt-devel at lists.openwrt.org
> > Cc: Brian Norris <computersforpeace at gmail.com>
> > Subject: [RFC PATCH 3/5] image-commands: support Chromium OS image-
> > type creation
> >
> > See the previous patches, which implemented the cros-vbutil verified-boot
> > payload-packing tool, and extended ptgen for the CrOS kernel partition type.
> > With these, it's now possible to package kernel + rootfs to make disk images
> > that can boot a Chrome OS-based system (e.g., Chromebooks, or even a few
> > AP models).
> >
> > gen_image_vboot.sh borrows a bit of structure from gen_image_generic.sh,
> > but I didn't feel it fit well to try and add new flags to the latter, given the
> > difference in its FAT kernel packaging and our raw kernel partition packing.
> >
> > Signed-off-by: Brian Norris <computersforpeace at gmail.com>
> > ---
> >  include/image-commands.mk  | 17 +++++++++++++++++
> > scripts/gen_image_vboot.sh | 29 +++++++++++++++++++++++++++++
> >  2 files changed, 46 insertions(+)
> >  create mode 100755 scripts/gen_image_vboot.sh
> >
> > diff --git a/include/image-commands.mk b/include/image-commands.mk
> > index e7db7128b4ca..ca8e826ffb1e 100644
> > --- a/include/image-commands.mk
> > +++ b/include/image-commands.mk
>
> Why is this added globally and not just for ipq40xx (same for the script)?
>
> Do you plan to use it for other targets?

Great question! Perhaps I should have noted that in the cover letter a
little more explicitly -- I noted that these image-generation commands
are applicable to all Chrome OS based devices (Chromebooks, etc.), but
there's one device in particular that may be quite relevant: Google
OnHub. It's got an IPQ8064 SoC running a Chrome OS stack, and I hear
there are some others who may be interested in porting to it too. I
don't have immediate plans to do that myself though, and if it's
preferred to start ipq40xx-local and move later if needed, I can do
that too.

Brian