[OpenWrt-Devel] [PATCH] ath79: switch to kernel 5.4

[mail at adrianschmutzler.de]

Hi,

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Daniel Golle
> Sent: Montag, 6. Juli 2020 01:03
> To: David Bauer <mail at david-bauer.net>
> Cc: Hauke Mehrtens <hauke at hauke-m.de>; openwrt-
> devel at lists.openwrt.org
> Subject: Re: [OpenWrt-Devel] [PATCH] ath79: switch to kernel 5.4
> 
> Hi David,
> 
> On Mon, Jul 06, 2020 at 12:37:06AM +0200, David Bauer wrote:
> > Hi Daniel,
> >
> > On 7/5/20 10:50 PM, Daniel Golle wrote:
> > > I suggest to completely remove KERNEL_TESTING_PATCHVER instead of
> > > setting it to the same version as KERNEL_PATCHVER.
> >
> > As most targets have it included, I've decided to specifically keep it.
> 
> Setting KERNEL_TESTING_PATCHVER enables the option in menuconfig to
> build with testing kernel. If set to the same version as KERNEL_PATCHVER,
> this is misleading as despite suggesting the use of a newer/testing version,
> obviously the exact same kernel version will be built.
> 
> You are right in that keeping it became the pattern once KERNEL_PATCHVER
> was bumped to the same level as KERNEL_TESTING_PATCHVER. I assume
> this was not deliberate (please scream now if it was!) we should also remove
> it from all other targets with KERNEL_PATCHVER ==
> KERNEL_TESTING_PATCHVER.

I also was a fan of keeping KERNEL_TESTING_PATCHVER recently, as this adding-and-removing-again seemed a bit unnecessary to me. However, your argument about menuconfig is valid.

I just wonder whether we, alternatively, could just check for KERNEL_PATCHVER == KERNEL_TESTING_PATCHVER in the code setting up menuconfig, and thus defeat the root cause....

Best

Adrian

> 
> Anyone?
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20200706/fcf1d377/attachment.sig>