[OpenWrt-Devel] [PATCH] ath79: switch to kernel 5.4

[David Bauer]

Hi Daniel

On 7/6/20 1:03 AM, Daniel Golle wrote:
> Hi David,
> 
> On Mon, Jul 06, 2020 at 12:37:06AM +0200, David Bauer wrote:
>> Hi Daniel,
>>
>> On 7/5/20 10:50 PM, Daniel Golle wrote:
>>> I suggest to completely remove KERNEL_TESTING_PATCHVER instead of
>>> setting it to the same version as KERNEL_PATCHVER.
>>
>> As most targets have it included, I've decided to specifically keep it.
> 
> Setting KERNEL_TESTING_PATCHVER enables the option in menuconfig to
> build with testing kernel. If set to the same version as
> KERNEL_PATCHVER, this is misleading as despite suggesting the use of a
> newer/testing version, obviously the exact same kernel version will be
> built.

Good to know. I was under the impression I've tested this and the menu option
was still visible when KERNEL_TESTING_PATCHVER was not present. Most likely i
fucked up while testing this.

> You are right in that keeping it became the pattern once
> KERNEL_PATCHVER was bumped to the same level as
> KERNEL_TESTING_PATCHVER. I assume this was not deliberate (please
> scream now if it was!) we should also remove it from all other targets
> with KERNEL_PATCHVER == KERNEL_TESTING_PATCHVER.

I agree here.

Best wishes
David

> 
> Anyone?
>