[OpenWrt-Devel] [PATCH 1/2] brcm47xx: rename target to bcm47xx

Russell Senior russell at personaltelco.net
Mon Feb 10 02:41:09 EST 2020


>>>>>   <mail at adrianschmutzler.de> writes:

>> >>>>> "Adrian" == Adrian Schmutzler <freifunk at adrianschmutzler.de>
>> writes:
>> 
Adrian> This change makes the names of Broadcom targets consistent by
Adrian> using the common notation based on SoC/CPU ID (which is used
Adrian> internally anyway), bcmXXXX instead of brcmXXXX.  This is even
Adrian> used for target TITLE in make menuconfig already, only the short
Adrian> target name used brcm so far.
>> 
>> This seems like an aesthetic change, but it will have more
>> consequential effects in tracing history and searching. I question
>> whether the tradeoff is worth it.

> Yes, it's purely cosmetical. However, I also don't see any big
> drawbacks.  The renames will be managed by git automatically, [...]

If I 'git mv target/linux/brcm47xx target/linux/bcm47xx', and then do
something like 'git log target/linux/bcm47xx', I don't see any of the
brcm47xx history.  That seems like a loss to me.


-- 
Russell Senior, President
russell at personaltelco.net

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list