[OpenWrt-Devel] [PATCH 1/2] brcm47xx: rename target to bcm47xx

mail at adrianschmutzler.de mail at adrianschmutzler.de
Sun Feb 9 09:30:05 EST 2020

> -----Original Message-----
> From: Russell Senior [mailto:russell at personaltelco.net]
> Sent: Sonntag, 9. Februar 2020 06:41
> To: Adrian Schmutzler <freifunk at adrianschmutzler.de>
> Cc: openwrt-devel at lists.openwrt.org
> Subject: Re: [OpenWrt-Devel] [PATCH 1/2] brcm47xx: rename target to
> bcm47xx
> >>>>> "Adrian" == Adrian Schmutzler <freifunk at adrianschmutzler.de>
> writes:
> Adrian> This change makes the names of Broadcom targets consistent by
> Adrian> using the common notation based on SoC/CPU ID (which is used
> Adrian> internally anyway), bcmXXXX instead of brcmXXXX.  This is even
> Adrian> used for target TITLE in make menuconfig already, only the short
> Adrian> target name used brcm so far.
> This seems like an aesthetic change, but it will have more consequential
> effects in tracing history and searching. I question whether the tradeoff is
> worth it.

Yes, it's purely cosmetical. However, I also don't see any big drawbacks.
The renames will be managed by git automatically, there are no references to the target names in packages or luci repos.
Despite, I consider it more confusing to have different naming schemes between and inside targets than to account for one target rename.



> --
> Russell Senior, President
> russell at personaltelco.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20200209/c6254639/attachment.sig>
-------------- next part --------------
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list