[PATCH 3/4] build: image: remove strange useless comment

Adrian Schmutzler mail at adrianschmutzler.de
Thu Aug 6 18:12:54 EDT 2020


> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Jo-Philipp Wich
> Sent: Donnerstag, 6. August 2020 16:34
> To: openwrt-devel at lists.openwrt.org
> Subject: Re: [PATCH 3/4] build: image: remove strange useless comment
> 
> Hi Adrian,
> 
> >  compat_version=$(if
> > $(DEVICE_COMPAT_VERSION),$(DEVICE_COMPAT_VERSION),1.0)
> >  json_quote=$(subst ','\'',$(subst ",\",$(1)))
> > -#")')
> 
> This commit was most likely added to aid text editors with naive syntax
> highlighting capabilities that fail to properly detect the end of the string due
> to the unique Make escape semantics. I'd propose to leave it in place.
> 
> If you want, you could prefix it with something like "fix bad syntax
> highlighting: "

I see. Thanks for the enlightenment.

I will just not touch it and drop the patch.

> 
> ~ Jo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20200807/ccb6ba26/attachment.sig>


More information about the openwrt-devel mailing list