[PATCH 3/4] build: image: remove strange useless comment

Jo-Philipp Wich jo at mein.io
Thu Aug 6 10:33:58 EDT 2020


Hi Adrian,

>  compat_version=$(if $(DEVICE_COMPAT_VERSION),$(DEVICE_COMPAT_VERSION),1.0)
>  json_quote=$(subst ','\'',$(subst ",\",$(1)))
> -#")')

This commit was most likely added to aid text editors with naive syntax
highlighting capabilities that fail to properly detect the end of the string
due to the unique Make escape semantics. I'd propose to leave it in place.

If you want, you could prefix it with something like "fix bad syntax
highlighting: "

~ Jo

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20200806/7d10f1dc/attachment-0001.sig>


More information about the openwrt-devel mailing list