[OpenWrt-Devel] [PATCH 1/2] mac80211: add rtw88 driver

John Crispin john at phrozen.org
Mon Oct 21 16:42:12 EDT 2019

On 21/10/2019 21:31, David Bauer wrote:
> Hello John
> On 10/21/19 9:22 PM, John Crispin wrote:
>> On 21/10/2019 21:13, David Bauer wrote:
>>> +config-$(call config_package,rtw88) += RTW88
>>> +config-y += RTW88_CORE RTW88_PCI RTW88_8822BE RTW88_8822CE
>>> +
>> why not put it all behind config-$(call config_package,rtw88) ? of course kbuild will "is not set it" if the prior is not selected but you could be explicit here. its bikeshedding but I was wondering if I am missing the obvious here.
> Good point, i will adjust this here. It's a leftover from when i thought building seperate packages
> for each WiFi card is a good idea (which i don't think still is).
> Best wishes
> David

can you resend a V2 please, i'll mark this one as superseeded in that case

openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list