[OpenWrt-Devel] [PATCH v2 1/4] openssl: Upgrade to 1.1.0h

Philip Prindeville philipp_subx at redfish-solutions.com
Mon Jun 4 15:03:59 EDT 2018


> On Jun 4, 2018, at 10:27 AM, Eneas Ulir de Queiroz <cote2004-github at yahoo.com> wrote:
> Sorry about the typos and spacing changes.  This should have never happened.  Thank you for pointing them out.  I have corrected them in the PR I've opened on github.  Since I'm new to the mailing list and don't know what the best way to proceed, please advise me.  I have 4 patches all related to the openssl upgrade.  John asked me earlier to send the whole bundle, so that people wouldn't need to search for them all over the list.  Now I have to change just one of them.  Should I repost all 4, or is it OK to do a V3 for just the openssl patch?

The 4 patches could be done as 4 PR’s or 1 PR with 4 commits on Github.

Using GitHub eliminates the issue of versioning patches… You only ever pay attention to what’s most recent.

But if you want to use email, you can just repost the one changed one, indicating a new version number (v2 or v3, etc).

> Since it's only the text I'm changing, I don't feel the need to do it right away--I still have plenty of pull requests to send to the packages feed.  I will change the PR I've opened in github right away, but I feel like I'm polluting the mailing list if I do it just for some typos in the text.  If there are nothing else to change, my intent is to repost the patch after I'm finished with the packages feed.

Well, that’s the nice thing about GitHub… you can revise as much as you like (or as much as is necessary) and there’s no mailing list pollution.

When you’re reasonably certain that the current version is the final one, then you can send an email asking for more eyes on it.

> By the way, here's the progress with the packages that depend on openssl (packages that were added or removed after I posted the patch are not tallied):
> Global Progress
> ---------------
> Total packages                     152    100,00%
> Packages that worked right away    109     71,71%
> Packages working now               122     80,26%
> Packages that still need changes    30     19,74%

Hmmm… not sure what these numbers mean.

I know what they mean superficially, but… are we assuming that 100% of the packages worked *before* the version upgrade?  Because that would seem unlikely.  OpenWrt is a very dynamic mix of projects and it’s more often the case than not that something’s broken, and a lot of things rely on OpenSSL, so by inference, there’s a good chance that something is broken and that that something is OpenSSL-related…

Not a criticism of the project (or I wouldn’t be using it in production!), just a pragmatic acceptance of reality.

> PR Progress
> -----------
> Total packages that needed changes  43    100,00%
> PRs created                         32     74,42%
> Merged PRs                          13     30,23%
> Open PRs                            19     44,19%
> PRs to open                         11     25,58%
> As for the comment about dropping  the engines:  I'm removing the patch that dropped the engines, and adding some options to control their installation, not ditching the engines.

Thanks for that clarification.  It clears things up.


> Cheers,
> Eneas

openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list