[OpenWrt-Devel] [PATCH] linux-3.18: prevent redefinition of struct ethhdr

Alejandro Mery amery at geeks.cl
Mon Jun 22 16:08:33 EDT 2015


On 22/06/15 11:32, Karl Palsson wrote:
> Alejandro Mery <amery at geeks.cl> wrote:
>> when using musl packages include netinet/ether.h break because
>> struct ethhdr gets redefined.
>> this patch comes includes a patch originally from sabotage linux
>> and it has been submitted upstream https://lkml.org/lkml/2014/3/14/266
> If this gets merged, could we then drop the large and growing pile of
> musl ether.h patches in each of the packages?  Is this going to get
> _merged_ upstream, or was it just posted to LKML?  I didn't see any discussion of it there.

not sure if *all* related patches can be removed because some packages 
do very nasty stuff, but this at least fixes those not doing 
define/include witchcraft. also, here I'm only patching 3.18 and will 
4.0 need similar love.

this patch is happily used by openembedded and sabotage linux, but it 
might take a while upstream decides to take it into consideration... 
it's not that they enjoy becoming part of libc wars.

but they did at least replace the #ifdef __GLIBC__ with a #ifndef 
__KERNEL__ in libc-compat.h, and that's something :)

Alejandro Mery
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list