[OpenWrt-Devel] [PATCH] b53 kernel memory corruption fix

[Rafał Miłecki]

On 9 June 2015 at 11:57, blmink <blmink at mink.su> wrote:
> Hi,

We usually don't want "hi" and "hello" it commit messages ;)


> this patch fixes kernel memory corruption in b53 driver during device global
> reset, which causes kernel panic especially on 64bit platforms.

There is sth wrong with patch format I guess, patchwork didn't notice
it :( You may want to e.g. use git send-email in the future.


> Signed-off-by: Fedor Konstantinov <blmink at mink.su>
> ---

This is a magic place (in patch format) where you can add messages
that won't be applied with e.g. "git am". So it's perfect place for
"hi" etc. :)
Thanks for your patch.


> Index: target/linux/generic/files/drivers/net/phy/b53/b53_common.c
> ===================================================================
> --- target/linux/generic/files/drivers/net/phy/b53/b53_common.c (revision
> 45932)
> +++ target/linux/generic/files/drivers/net/phy/b53/b53_common.c (working
> copy)
> @@ -803,8 +803,8 @@
>         priv->enable_jumbo = 0;
>         priv->allow_vid_4095 = 0;
>
> -       memset(priv->vlans, 0, sizeof(priv->vlans) * dev->vlans);
> -       memset(priv->ports, 0, sizeof(priv->ports) * dev->ports);
> +       memset(priv->vlans, 0, sizeof(struct b53_vlan) * dev->vlans);
> +       memset(priv->ports, 0, sizeof(struct b53_port) * dev->ports);
>
>         return b53_switch_reset(priv);
>  }

-- 
Rafał
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel