RFR: Packages PR #30104 (add back udp-broadcast-relay-redux package)
Aaron Curley
accwebs at gmail.com
Wed Oct 28 19:40:36 PDT 2026
Hello,
Sorry to nag, but can I get a review of
https://github.com/openwrt/packages/pull/30104 when someone has a chance?
Probably it's getting missed due to the 'not following guidelines' tag.
To aid with reviewing, I've deliberately kept various commits separate
for now. The final state of the branch passes guidelines; it's the
intermediate commits that are failing.
Admittedly, my workflows might be different than most, but in doing
reviews, I usually prefer to see things like reverse merges and
whitespace changes as separate commits. This allows me to quickly
exclude those from the diff (after a quick once over) and focus on the
actual substantive changes. If that's not helpful, LMK and I will just
immediately squash now. I assume we will want to squash at the end
regardless once reviewed?
Also, while you're there, if you can give me a bit of guidance on
backports it would help me out. My intent was to backport this to the
25.x and 24.x lines since it should be drop-in compatible (for 24 at
least). Note:
* 24 has the package; points at now archived/EOL repo.
* 25 removed it due to the upstream going archived/EOL. A few people
moving to 25 from 24 have commented saying they are looking for it.
So this would be adding it to 25 in arrears, but I feel like it fits the
spirit of a backport. But let me know if this plan fits within the
guidelines of the project.
Please forgive any ignorance of project standards on my part. I
appreciate y'all and what this project does!
Regards,
Aaron Curley
accwebs at gmail.com
More information about the openwrt-devel
mailing list