[PATCH] realtek: netgear_gs310tp-v1: Document UART location and pinout
Sander Vanheule
sander at svanheule.net
Sun Apr 26 13:32:46 PDT 2026
Hi Uwe,
On Sun, 2026-04-26 at 18:44 +0200, Uwe Kleine-König wrote:
> Signed-off-by: Uwe Kleine-König <uwe at kleine-koenig.org>
> ---
> target/linux/realtek/dts/rtl8380_netgear_gs310tp-v1.dts | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/target/linux/realtek/dts/rtl8380_netgear_gs310tp-v1.dts
> b/target/linux/realtek/dts/rtl8380_netgear_gs310tp-v1.dts
> index dd5993ad6a8e..8d5d589716ed 100644
> --- a/target/linux/realtek/dts/rtl8380_netgear_gs310tp-v1.dts
> +++ b/target/linux/realtek/dts/rtl8380_netgear_gs310tp-v1.dts
> @@ -1,5 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0-or-later
>
> +/* Console on &uart1. Exposed on J1 (opposide of the SFP cages), 2=RX, 3=TX,
> 4=GND */
> +
This is pretty much already described by the nodes in rtl838x.dtsi:
aliases {
serial0 = &uart0;
};
chosen {
stdout-path = "serial0:115200n8";
};
Furthermore, the pinout is described in the message of commit c829bc1f2c3c
("realtek: Add support for Netgear S350 series switches GS308T and GS310TP")
that originally added support for this device.
So I'm inclined to NACK this patch, as it doesn't really add much info IMHO.
Best,
Sander
More information about the openwrt-devel
mailing list