UCI changes breaking Strongswan

[Philip Prindeville]

> On May 18, 2025, at 4:40 PM, Rosen Penev <rosenp at gmail.com> wrote:
> 
> On Sun, May 18, 2025 at 10:48 AM Robert Marko <robimarko at gmail.com> wrote:
>> 
>> On Sun, 18 May 2025 at 19:46, Philip Prindeville
>> <philipp_subx at redfish-solutions.com> wrote:
>>> 
>>> 
>>> 
>>>> On May 18, 2025, at 11:42 AM, Robert Marko <robimarko at gmail.com> wrote:
>>>> 
>>>> On Sun, 18 May 2025 at 19:40, Philip Prindeville via openwrt-devel
>>>> <openwrt-devel at lists.openwrt.org> wrote:
>>>>> 
>>>>> The sender domain has a DMARC Reject/Quarantine policy which disallows
>>>>> sending mailing list messages using the original "From" header.
>>>>> 
>>>>> To mitigate this problem, the original message has been wrapped
>>>>> automatically by the mailing list software.
>>>>> 
>>>>> 
>>>>> ---------- Forwarded message ----------
>>>>> From: Philip Prindeville <philipp_subx at redfish-solutions.com>
>>>>> To: Philip Prindeville via openwrt-devel <openwrt-devel at lists.openwrt.org>
>>>>> Cc:
>>>>> Bcc:
>>>>> Date: Sun, 18 May 2025 11:39:49 -0600
>>>>> Subject: UCI changes breaking Strongswan
>>>>> The function uci_lookup() went away in UCI, and now Strongswan is broken (or at least the UCI plugin is).
>>>>> 
>>>>> It’s not clear what the equivalent replacement logic should be, using uci_lookup_next() or uci_lookup_ptr(), etc.
>>>>> 
>>>>> If one of the UCI maintainers could review and comment on:
>>>>> 
>>>>> https://github.com/openwrt/packages/pull/25353
> That PR probably works. Feel free to merge.


I’d like a little more certainty than “probably”.  Given it’s a 2-line patch you wouldn’t think finding a knowledgeable reviewer would be that hard… [cough]


>>>> 
>>>> Hi,
>>>> I pushed a fix making the UCI plugin depend on @BROKEN as its been
>>>> broken for like 9 years or so and OpenWrt
>>>> itself does not need it.
>>>> https://github.com/openwrt/packages/commit/a8c89a0c77b71c1699c57b7c6d70b034a271d678
>>>> 
>>>> So, it should now compile.
>>>> 
>>>> Regards,
>>>> Robert
>>> 
>>> 
>>> Thanks for doing that.  I’m thinking that it’s a relatively straightforward change to get it working again, if one of the UCI maintainers can give a couple of minutes of guidance.
>> 
>> Its probably not worth to put any time into the Strongswan UCI plugin,
>> given that its been broken for so long as it relied on API that is
>> long gone
>> then probably nobody cares about it.
>> 
>> Regards,
>> Robert
>> 
>>> 
>>> -Philip
>>> 
>>> 
>>>>> 
>>>>> that would be really helpful.
>>>>> 
>>>>> Thanks,
>>>>> 
>>>>> -Philip
>>>>> 
>>>>> 
>>>>> _______________________________________________
>>>>> openwrt-devel mailing list
>>>>> openwrt-devel at lists.openwrt.org
>>>>> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
>>>> 
>>>> _______________________________________________
>>>> openwrt-devel mailing list
>>>> openwrt-devel at lists.openwrt.org
>>>> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
>>> 
>> 
>> _______________________________________________
>> openwrt-devel mailing list
>> openwrt-devel at lists.openwrt.org
>> https://lists.openwrt.org/mailman/listinfo/openwrt-devel