PR review situation (was: Re: [PATCH 0/4] Series of minor fixes/cleanup for shell wrapper)

Philip Prindeville philipp_subx at redfish-solutions.com
Mon May 5 08:03:48 PDT 2025



> On May 5, 2025, at 12:27 AM, Bjørn Mork <bjorn at mork.no> wrote:
> 
> Philip Prindeville via openwrt-devel <openwrt-devel at lists.openwrt.org>
> writes:
> 
>> Note: there are PR's in GitHub for these, but it's not apparent if
>> anyone looks at those or not.
> 
> Not convinced that the mailing list is any better. There are 553 patches
> with state "action required" on
> https://patchwork.ozlabs.org/project/openwrt/list/ and that's not before
> there is a high volume of patches on this mailing list.
> 
> Around 400 of those patches are more than a year old.  They are not
> likely to ever see any action.
> 
> But some of the patches are probably already applied from github since
> this situation leads to desperate developers doing exactly what you do:
> Send duplicates in every possible channel.  I don't think that was the
> intention when it was decided to use both the mailing list and github
> PRs for patches.  And it's not likely to help those few who actually
> review and apply patches.
> 
> OK, looks like whining again.  It's not.  It's an attempt to describe
> the current imperfect state.  I have no real solution.  The obvious
> answer is that OpenWrt needs more active reviewers.  But how?
> 
> 
> 
> Bjørn


FWIW, my PR's were on GitHub for over a year before I emailed in patches.  I didn't just spam every means available.





More information about the openwrt-devel mailing list