[PATCH 3/4] jshn.sh: Name positional arguments
Philip Prindeville
philipp at redfish-solutions.com
Sun May 4 14:56:46 PDT 2025
From: Philip Prindeville <philipp at redfish-solutions.com>
Document the positional arguments to functions, and then use
those named variables inside the functions.
Signed-off-by: Philip Prindeville <philipp at redfish-solutions.com>
---
sh/jshn.sh | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/sh/jshn.sh b/sh/jshn.sh
index 3657642fd7673eeb417b0148af3e0b7c1e5c0825..c10ff3f154353c9a39b6b8ea9646464211450d86 100644
--- a/sh/jshn.sh
+++ b/sh/jshn.sh
@@ -222,6 +222,7 @@ json_dump() {
}
json_get_type() {
+ # target=$2
local __dest="$1"
local __cur
@@ -291,11 +292,11 @@ json_select() {
local type
local cur
- [ -z "$1" ] && {
+ [ -z "$target" ] && {
_json_set_var JSON_CUR "J_V"
return 0
}
- [[ "$1" == ".." ]] && {
+ [[ "$target" == ".." ]] && {
_json_get_var cur JSON_CUR
_json_get_var cur "U_$cur"
_json_set_var JSON_CUR "$cur"
@@ -316,6 +317,8 @@ json_select() {
}
json_is_a() {
+ # target=$1
+ # type=$2
local type
json_get_type type "$1"
--
2.43.0
More information about the openwrt-devel
mailing list