[PATCH 1/2] kernel: netdevices: Create Realtek DSA switch packages

Luiz Angelo Daros de Luca luizluca at gmail.com
Fri Jan 17 08:10:13 PST 2025


> > The upstream was rearranged in such a way that reverses the relation
> > between subdrivers and interfaces. It will probably break your
> > packages.
>
> Indeed. It was a bit annoying...
>
> We are falling behind mainline again.
>
> > Maybe we should back port the upstream changes (and fixes),
> > similar to what I did in
> > https://github.com/luizluca/openwrt/commit/d145c6845d7cdd2d49722a85988f16b17014dfa4
> > (it needs to be updated and rebased). I might have time to rebase that
> > branch soon.
>
> What about we rebase and merge your branch instead?
> It looks very good to me.
>
> Two review comments:
>
> 1. You split the taggers to separate packages, but in practice that is
>   just surplus because the DSA modules are 1:1 mapped to the
>   taggers and the only possible user. Just put respective tagger
>   module into the rtl8366rb and rtl8365mb packages instead.
>   (This is what other DSA switches started doing...)
>
> 2. After that you can just autoload the modules:
>    AUTOLOAD:=$(call AutoProbe,rtl8366rb)
>    AUTOLOAD:=$(call AutoProbe,rtl8365mb)
>
> If you fix this we can just merge it, also it's great to have all the
> backported patches, especially for RTL8365MB so we can move
> these devices over to DSA.
>
> Yours,
> Linus Walleij

Hi Linus,

I'm working on https://github.com/openwrt/openwrt/pull/12864 first and
then I'll get into this.

Regards,

Luiz



More information about the openwrt-devel mailing list