[PATCH v3 3/4] ipq40xx: fix compatibility with linux-atm tools

[Hauke Mehrtens]

On 1/13/25 23:27, Sergey Ryazanov wrote:
> Hi Andre, Martin,
> 
> On 13.01.2025 14:17, Andre Heider wrote:
> 
>> At least on ipq40xx there's nothing writing the custom classes to qos- 
>>  >txtp.traffic_class, it's all just code that reads and checks for 
>> those, so it's basically useless and dead code. This removal here 
>> allows us to drop the atm.h patch.
> 
> I checked the git history, it looks like since 2007 only Lantiq's legacy 
> driver (now ltq-atm) and various compat patches (now MIPS-lantiq-add- 
> atm-hack.patch) are referencing ATM_VBR_NRT/ATM_VBR_RT/ATM_UBR_PLUS/ 
> ATM_GFR.
> 
> We have two options now. (a) Keep the Lantiq's hack in the tree for both 
> platform and keep the include path amend in linux-atm. (b) proceed with 
> this patch and probably backport it to v23 and v24. And with a follow up 
> patch remove the corresponding ATM hacks from Lantiq and eventually from 
> linux-atm.
> 
>> If that's the case too for lantiq, we could apply the same logic there 
>> and make linux-atm shared again?
> 
> Yep. I like the plan 'b' for cleaning the tree from vendor's hacks, stop 
> spreading them to other targets and simplifying maintenance.
> 
>> In any case, this set still works on my ipq40xx device and vdsl seems 
>> to work just fine!
> 
> Have you gave a change to this series, Andre?

Hi,

I am for plan b. If the atm code in the lantiq target does not need the 
changes to the kernel ABI I would prefer when we remove it and use the 
unmodified atm header files also for lantiq.

Hauke