[PATCH v2 2/2] qoriq: Switch to use a module for mv88e6xxx

Linus Walleij linus.walleij at linaro.org
Sun Jan 12 15:16:53 PST 2025


It's possible to add the driver for the Marvell MV88E6xxx DSA
switches using a module package rather than to compile it into
the kernel. For affected devices this saves a bit of space,
the DSA core alone is around 600 KB on ARM.

I could only find one device actually using this switch (I also
checked upstream DTS files) so I have added the package to that
one device.

In the config CONFIG_NET_DSA_TAG_TRAILER and CONFIG_NET_DSA_OCELOT
were also selected, which seems like mistakes. These taggers are
only used by the MV88E6060 and driver which is a separate switch
from MV88E6xxx and the Ocelot drivers such as
CONFIG_NET_DSA_MSCC_FELIX or CONFIG_NET_DSA_MSCC_SEVILLE
and no qoric platform seems to be using them, nor are they
selected in the config.

Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
---
 target/linux/qoriq/config-6.6       | 7 -------
 target/linux/qoriq/image/generic.mk | 2 +-
 2 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/target/linux/qoriq/config-6.6 b/target/linux/qoriq/config-6.6
index 28ece0679f7888b021fafc82e0db15ad89cb0878..225b80df541217b4938776b72db819648c9b3b8a 100644
--- a/target/linux/qoriq/config-6.6
+++ b/target/linux/qoriq/config-6.6
@@ -257,13 +257,6 @@ CONFIG_NEED_PER_CPU_EMBED_FIRST_CHUNK=y
 CONFIG_NEED_PER_CPU_PAGE_FIRST_CHUNK=y
 CONFIG_NEED_SG_DMA_LENGTH=y
 CONFIG_NET_DEVLINK=y
-CONFIG_NET_DSA=y
-CONFIG_NET_DSA_MV88E6XXX=y
-CONFIG_NET_DSA_TAG_DSA=y
-CONFIG_NET_DSA_TAG_DSA_COMMON=y
-CONFIG_NET_DSA_TAG_EDSA=y
-CONFIG_NET_DSA_TAG_OCELOT=y
-CONFIG_NET_DSA_TAG_TRAILER=y
 CONFIG_NET_EGRESS=y
 CONFIG_NET_FLOW_LIMIT=y
 CONFIG_NET_INGRESS=y
diff --git a/target/linux/qoriq/image/generic.mk b/target/linux/qoriq/image/generic.mk
index d2b60d22962f666a54c73022fdb45c223a9ce086..ade63ef8a062f940f2244f2adcd2fc3a0de42b91 100644
--- a/target/linux/qoriq/image/generic.mk
+++ b/target/linux/qoriq/image/generic.mk
@@ -7,7 +7,7 @@ define Device/watchguard_firebox-m300
   DEVICE_DTS_DIR := $(DTS_DIR)/fsl
   DEVICE_PACKAGES := \
 	kmod-gpio-button-hotplug kmod-hwmon-w83793 kmod-leds-gpio kmod-ptp-qoriq \
-	kmod-rtc-rs5c372a kmod-tpm-i2c-atmel
+	kmod-rtc-rs5c372a kmod-tpm-i2c-atmel kmod-dsa-mv88e6xxx
   KERNEL := kernel-bin | gzip | fit gzip $$(KDIR)/image-$$(firstword $$(DEVICE_DTS)).dtb
   KERNEL_SUFFIX := -fit-uImage.itb
   IMAGES := sdcard.img.gz sysupgrade.img.gz

-- 
2.47.1




More information about the openwrt-devel mailing list