package-pack.mk's use of $(info ...) broke pigeonhole package

[George Sapkin]

Hey Mike,

In addition to what Eric said wrt the info line, I looked into the pigeonhole
package definition and found it somewhat irregular.

PKG_VERSION_DOVECOT is read through the shell magic and will be 2.3.21, however
DOVECOT_VERSION is hardcoded to 2.3. So in case Dovecot is updated to the latest
version 2.4, this will break. So why not hardcode PKG_VERSION_DOVECOT as well?
And make a note that both packages' definitions need to be updated at the same
time.

Seeing that you're listed as the Pigeonhole maintainer, is there a chance these
get updated to 2.4.x for the pending 25.12 release? Might be a coincidence, but
both Dovecot and Pigeonhole have a matching version as of now - 2.4.2.


George

On Wed, Dec 31, 2025 at 3:43 AM W. Michael Petullo <mike at flyn.org> wrote:
>
> The pigeonhole package has used the following to determine the version
> of dovecot, which is needed to build pigeonhole:
>
> PKG_VERSION_DOVECOT:=$(shell make --no-print-directory -C ../dovecot/ val.PKG_VERSION V=s)
>
> However, OpenWrt commit 18029977 added "$$(info $(1) fused dependencies: $$(Package/$(1)/DEPENDS))"
> to include/package-pack.mk. This causes the make command above to print
> more than just dovecot's version. Here is the result:
>
> dovecot fused dependencies: libc, libopenssl3, librt, zlib, libbz2-1.0, libcap
> dovecot-utils fused dependencies: libc, dovecot2.3.21
> 2.3.21
>
> The breaks the definition of "PKG_VERSION_DOVECOT", which expects only
> "2.3.21".
>
> Was this verbosity related to fused dependencies intentional? Could it
> be made subject to V=x?
>
> An alternative is to add "| grep -v 'fused dependencies'" to pigeonhole's
> Makefile line, but this seems fragile. It would not handle similar
> additions in the future.
>
> --
> Mike
>
> :wq
>
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel